[Surrey] Adds externalId for jobs and reports

Surrey will be sending an externalId specifically to be used for imported jobs and reports https://3.basecamp.com/4020879/buckets/36546415/todos/7672617616#__recording_7683887161 https://mysociety.slack.com/archives/C06SKSH5KQT/p1722948392215939
mysociety · Aug 6, 2024 · 18693cc · 18693cc
1 parent 35780e6
commit 18693cc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/perllib/Open311/Endpoint/Integration/Boomi.pm b/perllib/Open311/Endpoint/Integration/Boomi.pm
@@ -179,10 +179,10 @@ sub _get_service_requests_for_integration_id {
     for my $result (@$results) {
         my ($id, $loggedDate, $e, $n) = do {
             if (my $enq = $result->{confirmEnquiry}) {
-                ($enq->{enquiryNumber}, $enq->{loggedDate}, $enq->{easting}, $enq->{northing});
+                ($enq->{externalId}, $enq->{loggedDate}, $enq->{easting}, $enq->{northing});
             } else {
                 my $job = $result->{confirmJob};
-                ("JOB_" . $job->{jobNumber}, $job->{entryDate}, $job->{easting}, $job->{northing});
+                ("JOB_" . $job->{externalId}, $job->{entryDate}, $job->{easting}, $job->{northing});
             }
         };
         $loggedDate = DateTime::Format::W3CDTF->parse_datetime($loggedDate);

diff --git a/t/open311/endpoint/surrey_boomi.t b/t/open311/endpoint/surrey_boomi.t
@@ -190,7 +190,7 @@ $lwp->mock(request => sub {
                 "results" => [
                     {
                         "confirmEnquiry" => {
-                            "enquiryNumber" => 136416,
+                            "externalId" => 136416,
                             "loggedDate" => "2024-07-26T08:42:52.000Z",
                             "statusCode" => "6000",
                             "subject" => {
@@ -222,7 +222,7 @@ $lwp->mock(request => sub {
                     {
                         "confirmJob" => {
                             "entryDate" => "2024-07-26T07:46:33.000Z",
-                            "jobNumber" => 569081,
+                            "externalId" => 569081,
                             "statusCode" => "2000",
                             "priorityCode" => "HW09",
                             "jobType" => {