Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove django-apptemplates. #118

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Remove django-apptemplates. #118

merged 1 commit into from
Mar 10, 2021

Conversation

dracos
Copy link
Member

@dracos dracos commented Mar 8, 2021

Recursive templates have been supported since Django 1.9,
though only documented in 3.1

Includes bits of the python3 branch which I should tidy up and PR, not sure why it wasn't, probably look at that first.

@dracos dracos requested a review from davea March 8, 2021 13:56
stripe==2.35.0

# Bulk lookup
xlrd<2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticketed #122.

Recursive templates have been supported since Django 1.9,
though only documented in 3.1.
@dracos dracos force-pushed the remove-apptemplates branch from 20ba11a to 34ee023 Compare March 10, 2021 09:48
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #118 (34ee023) into master (be85398) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files          48       48           
  Lines        2092     2092           
=======================================
  Hits         1804     1804           
  Misses        288      288           
Impacted Files Coverage Δ
mapit_mysociety_org/mapit_settings.py 63.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be85398...34ee023. Read the comment docs.

@dracos dracos merged commit 34ee023 into master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants