Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bromley] Disable 'Street Cleansing' categories when selection is in park. #5283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neprune
Copy link
Contributor

@neprune neprune commented Dec 2, 2024

@neprune neprune changed the title [Bromley] Disable 'Street Cleansin' categories when selection is in park. [Bromley] Disable 'Street Cleansing' categories when selection is in park. Dec 2, 2024
@neprune neprune force-pushed the bromley-disable-street-cleansing-in-parks branch from 21546c5 to 5a896b3 Compare December 2, 2024 14:23
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.34%. Comparing base (0d4d098) to head (ac325a8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5283   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files         413      413           
  Lines       32719    32726    +7     
  Branches     5241     5241           
=======================================
+ Hits        26942    26949    +7     
  Misses       4225     4225           
  Partials     1552     1552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neprune neprune force-pushed the bromley-disable-street-cleansing-in-parks branch from 5a896b3 to 192b11d Compare December 2, 2024 16:15
@neprune neprune marked this pull request as ready for review December 2, 2024 16:15
@neprune neprune requested a review from dracos December 2, 2024 16:16
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a JS test :-)
(Perhaps we should improve that road_not_found second function thing at some point, I think it's do with TfL being available as well or similar, not sure how best to deal with it.)

@neprune neprune force-pushed the bromley-disable-street-cleansing-in-parks branch from 192b11d to ac325a8 Compare December 9, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants