Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bexley WW container requests: post go-live amendments #5282

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nephila-nacrea
Copy link
Contributor

For https://github.com/mysociety/societyworks/issues/4520.

[skip changelog]

@nephila-nacrea nephila-nacrea self-assigned this Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.44%. Comparing base (06d2a15) to head (bff0707).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5282      +/-   ##
==========================================
+ Coverage   82.37%   82.44%   +0.06%     
==========================================
  Files         413      413              
  Lines       32672    33007     +335     
  Branches     5236     5340     +104     
==========================================
+ Hits        26915    27212     +297     
- Misses       4208     4234      +26     
- Partials     1549     1561      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine; another option would be to rename the category, presumably, which would be a smaller change? But all the categories do match at present, I guess.

@nephila-nacrea
Copy link
Contributor Author

Looks fine; another option would be to rename the category, presumably, which would be a smaller change? But all the categories do match at present, I guess.

I wasn't sure I should be changing the category name because I'd thought other cobrands used the same name, but I think I may be mistaken on that. Can have another look and see if I can do that as a simpler change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants