-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bromley] Include notes in updates from Echo #5277
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5277 +/- ##
==========================================
+ Coverage 82.35% 82.37% +0.01%
==========================================
Files 413 413
Lines 32668 32673 +5
Branches 5236 5236
==========================================
+ Hits 26904 26914 +10
+ Misses 4215 4211 -4
+ Partials 1549 1548 -1 ☔ View full report in Codecov by Sentry. |
d19e95a
to
abd10c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright to me as far as I can tell. I'm just not very clear on the journey of a report being referred to Bromley from Echo or vice versa.
foreach (@$data) { | ||
$notes = $_->{Value} if $_->{DatatypeName} eq 'Veolia Notes'; | ||
} | ||
|
||
# An update from Echo with resolution code 1252 | ||
my $code = $comment->get_extra_metadata('external_status_code') || ''; | ||
if ($code eq '1252') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it would be good to have a comment or constant to explain what code 1252 refers to exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this could certainly do with more description (and on the wiki too, now the project's live). Hopefully the "redirecting of reports between backends" tests in t/cobrand/bromley.t
at least show the behaviour of things bouncing back and forth.
(Basically, if a report is sent to Echo, they can refer it to Bromley by sending a '1252' update code to us)
If a report was originally sent to Echo, then referred to Bromley more than once, we do not want to send the report to Bromley more than once.
abd10c5
to
65a3a6f
Compare
And fix issue with being redirected from Echo to Bromley more than once.
Fixes https://github.com/mysociety/societyworks/issues/4633 [skip changelog]