[Bexley] Add customised map pins #5275
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5275 +/- ##
==========================================
+ Coverage 82.25% 82.61% +0.36%
==========================================
Files 412 413 +1
Lines 32393 33583 +1190
Branches 5175 5550 +375
==========================================
+ Hits 26644 27745 +1101
- Misses 4204 4260 +56
- Partials 1545 1578 +33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Not sure what package was used to change the colours, but it's made them very jaggedy in doing so - compare e.g. https://github.com/mysociety/fixmystreet/blob/dc1ba7b689138aa5a6efa0755d61fe0eeeda244d/web/cobrands/bexley/images/pin-aqua-big.png vs https://github.com/mysociety/fixmystreet/blob/master/web/i/pin-yellow-big.png
So that needs sorting somehow, I'm afraid
| return 'orange' if $p->state eq 'action_scheduled'; | ||
| return 'green' if $p->is_fixed; | ||
| return 'spring' if $p->is_closed; | ||
| return 'grape' if $p->state eq 'not_council_responsibility'; |
There was a problem hiding this comment.
This line will never be reached because it'll match on the is_closed line above.
https://mysocietysupport.freshdesk.com/a/tickets/4521 https://github.com/mysociety/societyworks/issues/4626
[skip changelog]