[Surrey] [Hart] Continue button should not be visible when disabled #5267
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5267 +/- ##
==========================================
+ Coverage 82.24% 82.67% +0.42%
==========================================
Files 412 413 +1
Lines 32386 33457 +1071
Branches 5173 5493 +320
==========================================
+ Hits 26637 27660 +1023
- Misses 4206 4232 +26
- Partials 1543 1565 +22 ☔ View full report in Codecov by Sentry. |
dracos
approved these changes
Nov 22, 2024
MorayMySoc
changed the title
dracos
approved these changes
Nov 28, 2024
Reported that users think the button is broken and don't read the message above for an explanation of why they can't proceed https://mysocietysupport.freshdesk.com/a/tickets/4768
dracos
force-pushed
the
fd-4768-surrey-continue-button
branch
from
7263e2c
to
42fe86b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported that users think the button is broken and don't read the message above for an explanation of why they can't proceed
https://mysocietysupport.freshdesk.com/a/tickets/4768
https://mysocietysupport.freshdesk.com/a/tickets/4818
[skip changelog]