[Merton][WW] Allow transfer of ggw subscription #5232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5232 +/- ##
==========================================
+ Coverage 82.36% 83.07% +0.70%
==========================================
Files 409 410 +1
Lines 31999 34313 +2314
Branches 5095 5604 +509
==========================================
+ Hits 26356 28504 +2148
- Misses 4136 4257 +121
- Partials 1507 1552 +45 ☔ View full report in Codecov by Sentry. |
mysociety-pusher
force-pushed
the
4551-merton-ggw-transfers
branch
from
8e84931
to
0960734
Compare
dracos
requested changes
Oct 29, 2024
mysociety-pusher
force-pushed
the
4551-merton-ggw-transfers
branch
from
0960734
to
ea27997
Compare
dracos
requested changes
Oct 31, 2024
dracos
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Almost, but... the childdata might be a hash or an array, I'm afraid! See the double loop for the same type of data at https://github.com/mysociety/fixmystreet/blob/master/perllib/FixMyStreet/Roles/Cobrand/Echo.pm#L415
dracos
approved these changes
Nov 1, 2024
When a Green Garden Waste subscriber in Merton moves to another address in Merton, they can transfer the remainder of their ggw subscription to the new address 1) As long as the new address does not already have a sub 2) As long as there is a ggw on their previous property, and it is not in the renewal period 3) They have brought their bin(s) with them This is a staff only feature. mysociety/societyworks#4551
mysociety-pusher
force-pushed
the
4551-merton-ggw-transfers
branch
from
34fd44f
to
cdc210c
Compare
dracos
approved these changes
Nov 1, 2024
dracos
approved these changes
Nov 5, 2024
|
open311 changes also in 4551-merton-ggw-transfers on servers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Green Garden Waste subscriber in Merton moves to another address in Merton, they can transfer the remainder of their ggw subscription to the new address
This is a staff only feature.
https://github.com/mysociety/societyworks/issues/4551
[skip changelog]