-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Island Roads] Default 'CONFIRM Subject' to be a blank selection #5188
base: master
Are you sure you want to change the base?
Conversation
A 'Please select' option with a blank value is added under every group header in the dropdown; this is selected by default (under the relevant header) to force the admin user to choose a triage category (rather than it defaulting to the first category in the group).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5188 +/- ##
==========================================
+ Coverage 82.49% 82.61% +0.11%
==========================================
Files 406 406
Lines 31723 31990 +267
Branches 5048 5110 +62
==========================================
+ Hits 26171 26428 +257
- Misses 4062 4071 +9
- Partials 1490 1491 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but almost all of the two halves of the IF are the same, so can we have a much smaller IF inside? It looks to me you only need to change the inmost option-related bit. IF IoW, print out blank; and the existing selected IF could be dropped entirely I think, as that only applies for IoW.
Also stick a required on the <select>
(in general, that can be I think) :)
9a015c7
to
c3c9d74
Compare
@dracos Not sure I did it in quite the way you asked but it's compact and seems to work :-) Also added some tests. |
c3c9d74
to
9e5465d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yep, looks good :)
A 'Please select' option with a blank value is added under every group header in the dropdown; this is selected by default (under the relevant header) to force the admin user to choose a triage category (rather than it defaulting to the first category in the group).
[skip changelog]