-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homepage layout and new advanced filters #697
Conversation
39096b0
to
14b4086
Compare
375dbd3
to
e0f5980
Compare
95ef41c
to
b234ace
Compare
- Added "Go to section" in hero section - Jump to council in navbar pop up more - Advanced filters are now visible on desktop
a1a3ab4
to
2b6cd72
Compare
2b6cd72
to
14cf17f
Compare
Hey @zarino a few notes:
Let me know if you have any feedback =) |
Thanks @lucascumsille. While this resolves the requirements in #694 (and would eventually resolve #611 too) I wonder whether we’re just over-complicating everything. When I look at the homepage, as it stands in this PR, my eye is darting all over the place – there’s a sea of different buttons and boxes and labels and headers and form elements and borders. Sometimes a purple roundrect means "this option is selected", sometimes it means "submit the changes in this form". And four of the main controls on the page (the council type buttons – CE UK splits all of their analysis by these types, and councils can’t be compared across these types, so they feel philosophically quite different to the other more ephemeral filters) are counter-intuitively some of the smallest controls on the page, hidden in the middle of a whole bunch of other identical buttons and form elements. Now, I can see how we’ve got to this point. The requirements for this page have grown organically over time, and each time CE UK requests that we emphasise one bit over the others just a little bit more, we make a few more tweaks, add a few more boxes, another competing splash of colour… it’s an arms race. I do wonder whether, actually, this is the point at which we have an opportunity to simplify rather than complicate. So, getting back to basics, what do I think works about where we’ve got so far?
What am I not so sure about?
Rather than just complaining, I figured I’d try resolving these things. 🤣 I’m not saying this is perfect, but maybe it’ll do a better job of explaining what I mean by "simplify things". I’ll explain my thinking here:
I admit, this is pretty radical. I’m sure there are edge-cases I’ve not handled. But hopefully it shows there’s another way to approach this problem. Happy to discuss tomorrow! |
Thanks @zarino I like it, my only concern is that is for people that use or would like to use the advanced filters is not very encouraging. I don't think we have the data to know if people would use it or not, because in the current state, using the advanced filters is a bit of a pain. With you version I would:
Let me know what you think. I think we should show it to CEUK first, in case they have an option regarding the advanced filters, the thread is here. |
Yeah, I was toying with the idea of doing something like this, where, once a second filter has been applied ("Region: London" in this case), we break each filter group onto its own separate, labelled line: I haven’t actually tried it out in real life, though, so don’t know whether it’d feel a bit clunky. I expect there are other alternative solutions. |
I think I would stick to |
Replaced by: #706 |
Fixes: #611
Fixes: #694
Screen.Recording.2024-10-30.at.14.43.59.mov