Stripe API upgrade

[gbp]

What does this do?

Upgrades the Stripe API version used.

Why was this needed?

To hopefully help in migrating from Stripe plans to prices which in turn will help us add new prices and change existing subscriptions.

[gbp]

https://docs.stripe.com/changelog/2019-03-14/renames-date-field-invoices-created

There are a few changes to the invoice object:

• The date property has been renamed to created.

Need to change

alaveteli/app/views/alaveteli_pro/invoices/_invoice.html.erb

Line 2 in fb4d9f5

<strong><%= invoice.date.to_fs(:long) %></strong>

and

alaveteli/app/models/alaveteli_pro/invoice.rb

Line 17 in fb4d9f5

def date

Should also add test examples to catch this.

[gbp]

https://docs.stripe.com/changelog/2018-02-05/plans-link-individual-products-several-fields-moved

Each plan object is now linked to a product object .... The plan object ... and name attributes have been moved to product objects, and plan objects now have a nickname attribute.

Need to change

alaveteli/app/views/alaveteli_pro/plans/show.html.erb

Line 32 in fb4d9f5

<%= @plan.name %>

and

alaveteli/app/views/alaveteli_pro/subscriptions/_subscription.html.erb

Line 4 in fb4d9f5

<%= subscription.plan.name %>

Should also add test examples to catch this.

[gbp]

https://docs.stripe.com/changelog/2018-07-27/coupons-use-floats-specify-percent-off

The percent_off field of coupons was changed from Integer to Float, with a precision of two decimal places.

Need to check the calculations in

alaveteli/app/models/alaveteli_pro/subscription_with_discount.rb

Lines 74 to 80 in fb4d9f5

	def coupon_reduction(net)
	if coupon.amount_off
	BigDecimal((coupon.amount_off * 0.01), 0).round(2)
	else
	(net * coupon.percent_off / 100)
	end
	end

[gbp]

The above comments have been addressed. While I can write failing tests for them (stripe-ruby-mock doesn't enforce valid attributes, and it does expand Stripe resources) I have ensured they are all fixed.

[dracos]

One question about a plan.name that's left. There's also one more mention in app/models/webhook.rb that could be updated, but I guess you'd have to call something else to get the product name - the webhook includes the new data as well as the old, I've just checked (e.g. https://dashboard.stripe.com/events/evt_1QA8dQLoAAr9vgdbpgEl1nZm ) so you could switch there, but might not be worth it.

[dracos]

Sorry, after reviewing the last PR (incoming soon), I have a question - the commit message here says "Bumps the API version to the latest version support by stripe-ruby-mock." - but according to https://github.com/stripe-ruby-mock/stripe-ruby-mock/blob/master/CHANGELOG.md it supports up to SDK v11 which is the most recent Stripe SDK? Just checking I hadn't missed something there. Think the only major change since the one you're upgrading to here is the change from tax_percent to tax rate IDs.

[gbp]

In the stripe-ruby-mock readme they specify their target API version.

I tried later versions of the Stripe API version but unfortunately it resulted in so many broken specs.

The change to allow SDK v11 is just a change to relax the version requirement on the main Stripe ruby client gem. It does nothing to actually support those changes.