WIP Use commonlib function to create template_utf8 #2731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, didn't realise you were still working on this - should have kept you more up-to-date with progress. |
|
@crowbot, no worries, the only reason I took another look is because @garethrees re-assigned the original issue to me. It looks like he might have fixed it in the meantime and forgotten though.. |
stevenday
force-pushed
the
issues/2501-utf8-db-template
branch
from
f3ac4e9 to
cc490ad
Compare
stevenday
changed the title
stevenday
changed the title
|
Hmm, I'm going to scrap this because it's not working as I expected and I don't really have time to figure out why and it's not solving an actual problem in alaveteli anymore anyway (site-specific-install.sh can't find the function from commonlib for some reason). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at #2501, following @dracos' comments on the last one.
Adds a new function to commonlib (see related PR here
mysociety/commonlib#42) to create the template and
then uses it in the
install-as-userscript as before.Closes #2501