Skip to content

Commit

Permalink
Remove broken Google Chart
Browse files Browse the repository at this point in the history
Has been deprecated since 2012 and they've actually removed it over the
last year. Would be nice to replace with something else, but for now
this just removes the broken element.

Fixes #2366
  • Loading branch information
garethrees committed Nov 22, 2024
1 parent 9153a2c commit 88c70fe
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
15 changes: 6 additions & 9 deletions app/views/request_game/play.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,12 @@

<div id="game_sidebar" class="game_sidebar">
<p style="text-align: center">
<%= image_tag "https://chart.googleapis.com/chart?chs=250x125&cht=gom&chd=t:#{@percentage}",
:size => "250x125",
:alt => "A chart showing #{@percentage}% of requests have been categorised",
:title => "#{@percentage}% of requests have been categorised" %>
<br><%= n_("{{number_of_requests}} request left to categorise / {{total_number_of_requests}} total",
"{{number_of_requests}} requests left to categorise / {{total_number_of_requests}} total",
@missing,
:number_of_requests => number_with_delimiter(@missing),
:total_number_of_requests => number_with_delimiter(@total)) %>
<br />
<%= n_('{{number_of_requests}} request left to categorise / {{total_number_of_requests}} total',
'{{number_of_requests}} requests left to categorise / {{total_number_of_requests}} total',
@missing,
number_of_requests: number_with_delimiter(@missing),
total_number_of_requests: number_with_delimiter(@total)) %>
</p>

<h2><%= _("Top recent players") %></h2>
Expand Down
1 change: 1 addition & 0 deletions doc/CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Highlighted Features

* Remove deprecated Google Chart from request game (Gareth Rees)
* Migrated from Stripe Plans to Stripe Prices (Graeme Porteous)
* Change notes so that records tagged with `name:value` will be associated with
notes tagged as `name` (Graeme Porteous)
Expand Down

0 comments on commit 88c70fe

Please sign in to comment.