Skip to content
This repository has been archived by the owner on Jun 22, 2018. It is now read-only.

Adding composer to docker-compose file #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

euantorano
Copy link
Member

Allows composer to be ran using docker-compose run composer {command} - eg: docker-compose run composer update

Allows composer to be ran using `docker-compose run composer {command}`

Signed-off-by: Euan Torano <[email protected]>
@kawaii
Copy link
Member

kawaii commented Dec 28, 2017

Thanks Euan, I'll be away from home for most of the holiday period and not able to test this easily until after the first week in January. I'll let you know as soon as I've had the chance!

@@ -60,6 +60,12 @@ services:
- backend
restart: on-failure

composer:
image: composer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pin this image to a specific version, i.e. composer:1.6.

Copy link
Member

@kawaii kawaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composer image should be pinned to a specific version as per best practices for Docker.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants