Add cache mode param properly #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radu-todirica
force-pushed
the
feature/enaMaster-addCacheModeParamProperly
branch
from
459c348 to
ec4d15e
Compare
Added integration tests for the cache mode changes
radu-todirica
force-pushed
the
feature/enaMaster-addCacheModeParamProperly
branch
from
978953a to
8afdde8
Compare
nathanejohnson
pushed a commit
that referenced
this pull request
Jan 28, 2021
This adds the rules tab for IAM/roles. Fixes #45 Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now for the createDiskOffering indicates that the cacheMode parameter comes back in the response but there is no equivalent parameter in the request.
The following changes have been added:
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Wrote a python test for testing the creation of service offering with each one of the valid cache mode types : none, writeback and writethrough.
Wrote a python test for testing the creation of service offering with invalid cache mode type.
test_service_offerings_results.txt
test_service_offerings_runinfo.txt
Wrote a python test for testing the creation of disk offering with each one of the valid cache mode types : none, writeback and writethrough.
Wrote a python test for testing the creation of disk offering with invalid cache mode type.
test_disk_offerings_runinfo.txt
test_disk_offerings_results.txt