Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for 🤘 #53

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bug fix for 🤘 #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
caa3eed
Bug fix for :metal:
jagthedrummer Feb 13, 2021
9286ff7
Another tweak to match the cheat sheet
jagthedrummer Feb 18, 2021
2d11ac4
We should sort by hex, not by symbol to make 'zero width joiner' emoj…
jagthedrummer Feb 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rumoji/emoji.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def multiple?
# e.g. :man-man-boy: needs to come before :man: in the regex or else
# :man-man-boy: will never be matched
def <=>(other)
other.symbol <=> symbol
other.hex <=> hex
end

autoload :FOOD, 'rumoji/emoji/food'
Expand Down
4 changes: 2 additions & 2 deletions lib/rumoji/emoji/newmoji.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ class Emoji
self.new("\u{1F92C}", [:serious_face_with_symbols_covering_mouth]),
self.new("\u{1F92D}", [:smiling_face_with_smiling_eyes_and_hand_covering_mouth]),
self.new("\u{1F92E}", [:face_with_open_mouth_vomiting]),
self.new("\u{1F92F}", [:shocked_face_with_exploding_head]),
self.new("\u{1F92F}", [:exploding_head, :shocked_face_with_exploding_head]),
self.new("\u{1F930}", [:pregnant_woman]),
self.new("\u{1F931}", [:"breast-feeding"]),
self.new("\u{1F932}", [:palms_up_together]),
Expand Down Expand Up @@ -296,4 +296,4 @@ class Emoji
self.new("\u{2757}", [:heavy_exclamation_mark])
]
end
end
end
2 changes: 1 addition & 1 deletion lib/rumoji/emoji/people.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ class Emoji
self.new("\u{1F478}", [:princess]),
self.new("\u{1F595}", [:middle_finger], "REVERSED HAND WITH MIDDLE FINGER EXTENDED"),
self.new("\u{1F596}", [:vulcan_salute], "RAISED HAND WITH PART BETWEEN MIDDLE AND RING FINGERS"), # vulcan salute
self.new("\u{1F918}", [:sign_horns, :the_horns], "SIGN OF THE HORNS"),
self.new("\u{1F918}", [:metal, :sign_horns, :the_horns], "SIGN OF THE HORNS"),
self.new("\u{1F590}", [:fingers_splayed, :raised_hand_with_fingers_splayed], "RAISED HAND WITH FINGERS SPLAYED"),

# Cats
Expand Down