Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force namespace to be specified separately from tag #222

Merged
merged 4 commits into from
Jul 16, 2023
Merged

Force namespace to be specified separately from tag #222

merged 4 commits into from
Jul 16, 2023

Conversation

mvz
Copy link
Owner

@mvz mvz commented Jul 16, 2023

Fixes #217.

  • Extract HappyMapper::ClassMethods to its own file
  • Add development binstubs for bundle, rake and rspec
  • Disallow inclusion of namespace in tag name
  • Regenerate RuboCop to-do file

mvz added 4 commits July 16, 2023 13:35
@mvz
Extract HappyMapper::ClassMethods to its own file
1c43416
@mvz
Add development binstubs for bundle, rake and rspec
b88af90
@mvz
Disallow inclusion of namespace in tag name
9eca26f 
Putting the namespace in the tag name is not tested and not supported
and only works by accident on MRI, while resulting in an error on JRuby.

This change makes namespace separators explictly forbidden as part of a
tag name.
@mvz
Regenerate RuboCop to-do file
b1e8b12
@mvz mvz merged commit 17c9ba8 into master Jul 16, 2023
6 checks passed
@mvz mvz deleted the force-separate-namespace branch July 16, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JRuby NAMESPACE_ERR when root node has a namespace prefix
1 participant
@mvz