Change asio BUILD to be compatible with the BCR version
#343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalten
force-pushed
the
asio-bcr-compat
branch
2 times, most recently
from
5d21f2f
to
54cd64a
Compare
mvukov
reviewed
Jun 30, 2024
Wyverald
pushed a commit
to bazelbuild/bazel-central-registry
that referenced
this pull request
Aug 28, 2024
* Add the latest Asio release * Switch to "ASIO_SEPARATE_COMPILATION" (mvukov/rules_ros2#343) Needs the skip-url-stability label
lalten
force-pushed
the
asio-bcr-compat
branch
from
54cd64a
to
6e020a8
Compare
mvukov
approved these changes
Sep 1, 2024
trad0v
pushed a commit
to EddyGharib/rules_ros2
that referenced
this pull request
Oct 2, 2024
Co-authored-by: Milan Vukov <[email protected]>
parth-emancro
pushed a commit
to emancro/rules_ros2
that referenced
this pull request
Oct 2, 2024
Co-authored-by: Milan Vukov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off #238
Change
asioBUILD to be compatible with the BCR version:https://github.com/bazelbuild/bazel-central-registry/blob/b58c330b8386c64d38c3587c4a1c55ef344fce14/modules/asio/1.28.2/patches/add_build_file.patch
Note that foxglove_bridge_base was previously transitively depending on
@boringssl//:sslthroughasio.