Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add pod spec version check on release branch pushes #88

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

andrewjl-mux
Copy link
Contributor

@andrewjl-mux andrewjl-mux commented Aug 1, 2023

This check only handles Cocoapods at the moment, checking Version.swift requires additional tooling and will be added in a separate pull request.

Here's an example of a detected version mismatch on a mock release branch: https://github.com/muxinc/swift-upload-sdk/actions/runs/5721374427/job/15502867962

@andrewjl-mux andrewjl-mux requested a review from a team August 1, 2023 01:17
@andrewjl-mux andrewjl-mux mentioned this pull request Aug 1, 2023
Copy link
Contributor

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Approved with a couple of nb suggestions

scripts/version-check.sh Outdated Show resolved Hide resolved
.github/workflows/validate-release.yml Outdated Show resolved Hide resolved
@andrewjl-mux andrewjl-mux merged commit 0478918 into main Aug 1, 2023
@andrewjl-mux andrewjl-mux deleted the ajlb/ci/check-pod-spec-version branch August 1, 2023 22:32
@andrewjl-mux andrewjl-mux changed the title ci: add version check on release branches ci: add pod spec version check on release branch pushes Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants