Remove prefix use in public APIs and respell Upload as DirectUpload #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirectUploadManagerDelegate.uploadListUpdated(with:) -> DirectUploadManagerDelegate.didUpdate(managedDirectUploads:) DirectUploadManager.allManagedUploads() -> DirectUploadManager.allManagedDirectUploads() DirectUploadManager.findStartedUpload(ofFile:) -> DirectUploadManager.startedDirectUpload(ofFile:) DirectUploadManager.resumeUpload(ofFile:) -> DirectUploadManager.resumeDirectUpload(ofFile:) DirectUploadManager.resumeUpload(ofFile:completion:) -> DirectUploadManager.resumeDirectUpload(ofFile:completion:) DirectUploadManager.resumeAllUploads() -> DirectUploadManager.resumeAllDirectUploads()
andrewjl-mux
changed the title
daytime-em
approved these changes
Jul 31, 2023
Remove Error.parseAsUploadError(lastSeenUploadStatus:)
uploadSucceeded -> finished, wraps DirectUploadResult uploadFailed -> finished, wraps DirectUploadResult
awaitingUploadConfirmation -> awaitingConfirmation uploadInProgress -> transportInProgress uploadPaused -> paused
To distinguish from DirectUploadResult.success
andrewjl-mux
force-pushed
the
ajlb/remove-mux-prefix
branch
from
22e3ac2
to
a256147
Compare
Merged
andrewjl-mux
added a commit
that referenced
this pull request
Jul 31, 2023
tomkordic
pushed a commit
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent prefix name confusion when we add an Obj-C wrapper module remove the Mux prefix from those types that have it.
Make more apparent the difference between the
Uploadreturned in the Mux API response from the direct upload type in the SDK by usingDirectUploadinstead ofUpload. (Also slightly reduces the chance use of a fully disambiguated type name MuxUploadSDK.DirectUpload will be required.)API Changes
MuxUpload->DirectUploadUploadManager->DirectUploadManagerDirectUploadManager.allManagedUploads()->DirectUploadManager.allManagedDirectUploads()DirectUploadManager.findStartedUpload(ofFile:)->DirectUploadManager.startedDirectUpload(ofFile:)DirectUploadManager.resumeUpload(ofFile:)->DirectUploadManager.resumeDirectUpload(ofFile:)DirectUploadManager.resumeUpload(ofFile:completion:)->DirectUploadManager.resumeDirectUpload(ofFile:completion:)DirectUploadManager.resumeAllUploads()->DirectUploadManager.resumeAllDirectUploads()UploadsUpdateDelegate->DirectUploadManagerDelegateDirectUploadManagerDelegate.uploadListUpdated(with:)->DirectUploadManagerDelegate.didUpdate(managedDirectUploads:)MuxUpload.UploadError->DirectUploadErrorMuxErrorCase->DirectUploadError.KindDirectUpload.UploadError.code->DirectUploadError.kindError.asMuxUploadErrorError.parseAsUploadError(lastSeenUploadStatus:)MuxUploadSDK->SDKLogger(This only deals with logging)UploadOptions->DirectUploadOptionsDirectUpload.InputStatusDirectUpload.InputStatus.uploadSucceededandDirectUpload.InputStatus.uploadFailedtoDirectUpload.InputStatus.finishedDirectUpload.InputStatus.awaitingUploadConfirmationtoDirectUpload.InputStatus.awaitingConfirmationDirectUpload.InputStatus.uploadInProgresstoDirectUpload.InputStatus.transportInProgressDirectUpload.InputStatus.uploadPausedtoDirectUpload.InputStatus.pausedDirectUpload.Success->DirectUpload.SuccessDetailsUploadResult->DirectUploadResult