Track CSAI ad media failures #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ima into update/track-csai-fails
Tests are passing locally |
andrewjl-mux
reviewed
Apr 4, 2024
| if (adData && adData[@"logData"]) { | ||
| NSDictionary *errorLog = (NSDictionary *)adData[@"logData"]; | ||
| if (errorLog) { | ||
| if (errorLog[@"errorCode"] || errorLog[@"errorMessage"] || errorLog[@"type"]) { |
There was a problem hiding this comment.
Are these keys coming from IMA? (If so wondering if we can add a doc link if there is one to help future us)
There was a problem hiding this comment.
They come from IMA, yes but there's no public constants for them. I got these values by failing requests with proxyman then dumping events the IMASDKEvents to the logs
There was a problem hiding this comment.
There's a log snippet of the keys above ⬆️
edit: also you can try yourself on the log-ad-events branch.
Merged
daytime-em
added a commit
that referenced
this pull request
Apr 17, 2024
## Updates * Track CSAI ad media failures (#33) ## Improvements * Ima ads event data populated. (#30) * fix: `adplay` and `adresponse` sent at incorrect time (#32) Co-authored-by: Tomislav Kordic <[email protected]> Co-authored-by: Emily Dixon <[email protected]> Co-authored-by: GitHub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.