-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: seeking when preload is none #997
Conversation
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
25fe3fc
to
9794ad1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
- Coverage 78.55% 76.92% -1.64%
==========================================
Files 59 50 -9
Lines 11080 12102 +1022
Branches 0 699 +699
==========================================
+ Hits 8704 9309 +605
- Misses 2376 2768 +392
- Partials 0 25 +25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
related #910
this fixes an issue where when you seek before the video is loaded we don't set the video.currentTime.
it's fine to set the currentTime anytime. it doesn't throw for a valid number value.
but users have to set the
defaultduration
in some cases. not sure with iOS and native HLS.