Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a note about img tag in media-poster-image.mdx #907

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

ADTC
Copy link
Contributor

@ADTC ADTC commented May 11, 2024

This doc change is inspired by the comment by @luwes here:

#904 (comment)

PS: Maintainer edits are allowed. Feel free to change the text as you see fit.

This doc change is inspired by the comment by @luwes here:

muxinc#904 (comment)
@ADTC ADTC requested review from heff and a team as code owners May 11, 2024 17:24
Copy link

vercel bot commented May 11, 2024

@ADTC is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@luwes luwes changed the title Add a note about img tag in media-poster-image.mdx docs: Add a note about img tag in media-poster-image.mdx Sep 19, 2024
@luwes
Copy link
Contributor

luwes commented Sep 19, 2024

Thanks for the contribution!

@luwes luwes merged commit fa6ac52 into muxinc:main Sep 19, 2024
1 of 4 checks passed
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (3ea80df) to head (c441ede).
Report is 97 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
+ Coverage   78.55%   79.04%   +0.49%     
==========================================
  Files          59       50       -9     
  Lines       11080    12081    +1001     
  Branches        0      695     +695     
==========================================
+ Hits         8704     9550     +846     
- Misses       2376     2531     +155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ADTC ADTC deleted the patch-2 branch September 23, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants