Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip overflow causing scrollbar #1018

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Nov 5, 2024

@luwes luwes self-assigned this Nov 5, 2024
@luwes luwes requested review from heff and a team as code owners November 5, 2024 15:20
Copy link

height bot commented Nov 5, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

vercel bot commented Nov 5, 2024

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 3:21pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 3:21pm

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.95%. Comparing base (3ea80df) to head (c2329d7).
Report is 137 commits behind head on main.

Files with missing lines Patch % Lines
src/js/utils/element-utils.ts 60.00% 2 Missing ⚠️
src/js/media-tooltip.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
- Coverage   78.55%   76.95%   -1.61%     
==========================================
  Files          59       50       -9     
  Lines       11080    12124    +1044     
  Branches        0      705     +705     
==========================================
+ Hits         8704     9330     +626     
- Misses       2376     2768     +392     
- Partials        0       26      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AdamJaggard AdamJaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any scenarios where someone might want to explicitly/purposefully position a tooltip before revealing it? which I think this solution would block. Approved either way as I don't know if that is a real problem in practice and this looks like it fixes the known issue.

edit: on second thought, it can always be re-positioned upon eventually being shown so likely a non-issue

@luwes luwes merged commit 181aec2 into muxinc:main Nov 5, 2024
5 of 8 checks passed
@luwes luwes deleted the fix-tooltip-overflow branch November 5, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

menu button tooltip creates scroll bar
2 participants