-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tooltip overflow causing scrollbar #1018
Conversation
|
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1018 +/- ##
==========================================
- Coverage 78.55% 76.95% -1.61%
==========================================
Files 59 50 -9
Lines 11080 12124 +1044
Branches 0 705 +705
==========================================
+ Hits 8704 9330 +626
- Misses 2376 2768 +392
- Partials 0 26 +26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any scenarios where someone might want to explicitly/purposefully position a tooltip before revealing it? which I think this solution would block. Approved either way as I don't know if that is a real problem in practice and this looks like it fixes the known issue.
edit: on second thought, it can always be re-positioned upon eventually being shown so likely a non-issue
fix #1017
related muxinc/elements#865