Add rough support for Sony #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work is based on files from an a7r3, so it may not work with other models. The values used for calculations are guesses based on marketing material from Sony and trial and error. The intended features are the following. * Show the focus point that was used * Show the outer frame of the PDAF area * Show active PDAF locations Most Sony cameras that have PDAF only use it down to f/8 and only over a subset of the sensor, so the lack of related EXIF data should not be an error. No attempt was made to support eye/face detection, nor to identify the specific focus area used for a given image. Related to musselwhizzle#120
|
thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this plugin. I was able to get rough support for the a7r3 working. I don't have enough time to do much beyond this, but I wanted to contribute it back to the project. Hopefully this will be useful to some, and it can serve as a starting point for more robust support in the future.
This work is based on files from an a7r3, so it may not work with other
models. The values used for calculations are guesses based on marketing
material from Sony and trial and error. The intended features are the
following.
Most Sony cameras that have PDAF only use it down to f/8 and only over a
subset of the sensor, so the lack of related EXIF data should not be an
error. No attempt was made to support eye/face detection, nor to
identify the specific focus area used for a given image.
Related to #120