Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error for multi-arch Docker images #1

Closed
wants to merge 3 commits into from
Closed

Conversation

jlantz
Copy link

@jlantz jlantz commented Oct 29, 2024

Add multi-arch, multi-stage Dockerfile and update workflows for Docker builds.

  • Dockerfile: Add QEMU installation step for multi-arch support, add --platform flag for target architectures, and update SF_CLI_VERSION argument to use the latest version by default.
  • .github/workflows/build-docker.yml: Add if: github.event.repository.fork condition to restrict workflow to forks, set default value for version input to the latest sf CLI version, and update workflow to use a single callable workflow for multi-arch, multi-stage builds.
  • .github/workflows/test-docker.yml: Add if: github.event.repository.fork condition to restrict workflow to forks, set default value for version input to the latest sf CLI version, and update workflow to run and publish to the package registry in the repo to test the docker builds on every commit.
  • Deleted: Remove .github/workflows/build-docker-full.yml and .github/workflows/build-docker-slim.yml.

For more details, open the Copilot Workspace session.

Add multi-arch, multi-stage Dockerfile and update workflows for Docker builds.

* **Dockerfile**: Add QEMU installation step for multi-arch support, add `--platform` flag for target architectures, and update `SF_CLI_VERSION` argument to use the latest version by default.
* **.github/workflows/build-docker.yml**: Add `if: github.event.repository.fork` condition to restrict workflow to forks, set default value for `version` input to the latest `sf` CLI version, and update workflow to use a single callable workflow for multi-arch, multi-stage builds.
* **.github/workflows/test-docker.yml**: Add `if: github.event.repository.fork` condition to restrict workflow to forks, set default value for `version` input to the latest `sf` CLI version, and update workflow to run and publish to the package registry in the repo to test the docker builds on every commit.
* **Deleted**: Remove `.github/workflows/build-docker-full.yml` and `.github/workflows/build-docker-slim.yml`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/muselab-d2x/cli?shareId=XXXX-XXXX-XXXX-XXXX).
  - Add instructions for contributors to test Docker build workflows in their forks by creating a branch starting with `docker/`.
  - Include steps to test Docker build workflows.
  - Add information about the Salesforce Code of Conduct and license.
@jlantz jlantz closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant