Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop node v16 support #312

Merged
merged 10 commits into from
Dec 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
node-version: [16]
node-version: [18]
arch: [amd64, arm64, arm]
platform: [debian, alpine]
include:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-mac-m1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: macos-13
strategy:
matrix:
node-version: [16.x]
node-version: [18]

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-mac-x64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: macos-13
strategy:
matrix:
node-version: [16.x]
node-version: [18]

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-win.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: windows-2019
strategy:
matrix:
node-version: [16.x]
node-version: [18]

steps:
- uses: actions/checkout@v4
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: '16.x'
node-version: '18'
- run: npm ci
- run: npm run lint
- run: npm run test-types
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.15)
cmake_policy(SET CMP0091 NEW)
cmake_policy(SET CMP0042 NEW)

project(node_datachannel VERSION 0.22.0)
project(node_datachannel VERSION 0.23.0)

# -Dnapi_build_version=8
add_definitions(-DNAPI_VERSION=8)
Expand Down
2 changes: 1 addition & 1 deletion build-containers/Dockerfile.alpine
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG version=3.16
ARG node_version=16
ARG node_version=18
FROM node:${node_version}-alpine${version}
RUN apk add build-base openssl-libs-static openssl-dev

Expand Down
2 changes: 1 addition & 1 deletion build-containers/Dockerfile.debian
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG version=bullseye
ARG node_version=16
ARG node_version=18
FROM node:${node_version}-${version}
RUN apt update
RUN apt install -y build-essential libssl-dev
Expand Down
Loading
Loading