-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support setting ICE ufrag and pwd, disabling fingerprint validation and specifying certificates #256
base: master
Are you sure you want to change the base?
Conversation
Supports listening and dialing WebRTC Direct multiaddrs in Node.js. Depends on: - [ ] libp2p/go-libp2p#2827 - [ ] paullouisageneau/libdatachannel#1201 - [ ] paullouisageneau/libdatachannel#1204 - [ ] murat-dogan/node-datachannel#257 - [ ] murat-dogan/node-datachannel#256 Closes: - #2581
Supports listening and dialing WebRTC Direct multiaddrs in Node.js. Depends on: - [ ] libp2p/go-libp2p#2827 - [ ] paullouisageneau/libdatachannel#1201 - [ ] paullouisageneau/libdatachannel#1204 - [ ] murat-dogan/node-datachannel#257 - [ ] murat-dogan/node-datachannel#256 Closes: - #2581
Thanks for the PR.
|
2e41beb
to
4cb6ad1
Compare
Updates the implementation to match the latest libdatachannel with features for setting ICE ufrag/pwd and reading the remote cert fingerprint. Also adds pass-through for missing config values.
4c8b9b6
to
10051a8
Compare
Hello, When that could be ready for merging? |
@murat-dogan @achingbrain what remains before we can merge? |
For the functionality to be usable this PR needs to be merged/released as well - paullouisageneau/libjuice#248 - then this one: paullouisageneau/libdatachannel#1211 - then we can expose it here. |
given the delay, would it make sense to consider forking in the meantime? |
if ^ was a separate PR, do we have anything blocking us on the libdatachannel side? My reason for asking, I'm using a homegrown turn: server w/ local short circuit, and don't need the other parts, afaik. |
@paullouisageneau what do you think, will you have some time to let us merge the final couple of outstanding PRs (paullouisageneau/libjuice#248 and paullouisageneau/libdatachannel#1211) or should we do our own thing? |
Hi all, I think forking the lib is not feasible. To merge only fingerprint feature is something @achingbrain should decide, while he worked on this PR already. If this will be the case also this PR must be re-worked. |
I'll do another pass on paullouisageneau/libjuice#248 This issue was closed but as I understand it is still blocking, as the ICE ufrag and pwd can't be applied from the polyfill: paullouisageneau/libdatachannel#1218 |
Is there something that I can do @paullouisageneau ? |
paullouisageneau/libjuice#243 allows setting the ICE ufrag and pwd fields instead of generating random ones every time.
paullouisageneau/libdatachannel#1207 adds an
init
arg tosetLocalDescription
to allow setting the fields in libjuice from libdatachannel.paullouisageneau/libdatachannel#1206 allows reading the fingerprint of the cert being used by the remote peer.
This PR adds the
init
arg tosetLocalDescription
, and theremoteFingerprint
method, plus the missing config keys.This is required to implement libp2p WebRTC-Direct.
It will require the PRs above being merged and shipped before this is ready so I've opened it as a draft for now.
Refs: paullouisageneau/libdatachannel#1166