Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websocket functionality #235

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

ptesavol
Copy link
Contributor

Expose the WebSocket functionality of libdatachannel in node-datachannel

  • Change the compilation options of libdatachannel to enable WebSocket functionality
  • New Classes WebSocket and WebSocketServer
  • Simple websockets.js test
  • Typescript typings in which both DataChannel and WebSocket implement a common Channel interface so users can handle them in an uniform manner

ToDo:

  • WebSocket implementation is, for most part, a cut-and-paste from DataChannel functionality, maybe we should extract the common functionality into a superclass?
  • Add jest tests

@murat-dogan murat-dogan merged commit af26b72 into murat-dogan:master Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants