Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX types and add CI check for types #206

Merged
merged 3 commits into from
Nov 26, 2023
Merged

FIX types and add CI check for types #206

merged 3 commits into from
Nov 26, 2023

Conversation

pubkey
Copy link
Contributor

@pubkey pubkey commented Nov 21, 2023

The typescript types are broken and throw the following error:

error-types

This PR contains the following:

  • Fixes for the typings.
  • Update typescript to 5.3.2.
  • Add a CI check to ensure the types will not break in the future.

@pubkey pubkey mentioned this pull request Nov 21, 2023
Merged
@murat-dogan
Copy link
Owner

murat-dogan commented Nov 25, 2023 •
edited
Loading

Could you please add "build" to excludes in tsconfig.json?

@pubkey
Copy link
Contributor Author

pubkey commented Nov 25, 2023

@murat-dogan Yes I have added it in the latest commit.

@murat-dogan murat-dogan merged commit 02699b4 into murat-dogan:master Nov 26, 2023
1 check passed
@murat-dogan
Copy link
Owner

Thanks

@pubkey
Copy link
Contributor Author

pubkey commented Nov 29, 2023

@murat-dogan If you find the time, it would be great to have a new release. This is the last thing that blocks me from using node-datachannel.

@murat-dogan
Copy link
Owner

Just released 0.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pubkey @murat-dogan