Ensure deployment works again #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
update-dependencies
branch
3 times, most recently
from
10ae3cb to
d6d7665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took some tries, but I got it working again.
This PR fixes https://github.com/mupixa/deploy-lambda/issues.
I got on the correct path based on comments in this issue: claudiajs/claudia#226
Apparently, some change with AWS lead to it failing when we try to update the function code & config at the same time.
Instead, we need to wait for the function code to be updated, before we try to update the config.
I re-wrote this to use an async function and updated the dependencies to the latest version, while at it.
It is working in our apps now again, with these changes. The API does not change.