Fix for comment keymap on spanish keyboards #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, there seems to be a "code style issue" found, but there is no clear indication what my style issue is. So not sure how to fix this specifically. |
|
Okay, seems fixed now, the error was just because I use |
|
Thanks! I can test later today, I have a Spanish keyboard in one of my notebooks :) |
|
Thanks! I did test it and works great. I have a feeling this might cause issues for other non-spanish and non-english keyboard layouts though, but let's see if anyone complains and review it if that's the case. |
|
Yeah, maybe adding these explicit shortkeys could lead to issues on other language keyboards. Let's see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had several encounters with people who have a spanish keyboard layout, where the
cmd-/keymap to (un)comment doesn't work, because they need to typecmdshift7.I'm proposing this fix (that worked for me in the mercury editor on my site) where I just added the actual keycombination
shift-cmd-7andshift-alt-7(as alternative).I've also added
alt-/andctrl-/as extra alternatives. Thealt-/mainly because I'm used to using alt in Mercury to avoid clashes with other commands. Thectrl-/is maybe not so necessary but also doesn't hurt I guess.My fix here hasn't been tested on a Spanish keyboard yet, so I'm happy to hear feedback from users with such a keyboard.