-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox web languages using iframes #268
Conversation
1e05bae
to
8930c0f
Compare
I would have to investigate but currently mercury-web throws a |
Ah, yes, I know what this is about. Will fix it soon. |
@tmhglnd fixed now |
Yes all good now! |
Ah I spoke a bit too soon. Because now the Edit: I see you already made an issue for this in #272 |
Ouch, I knew I was forgetting something. Yes, I noticed about this (was thinking of another case..), but I was planning on solving this in #272 |
Fixes #239
Load web libraries in separate pages and embed them using iframes. This way, these libraries do not pollute the global Window from the session page and there are no collisions between the globals each library define.
Incidentally, this also fixes #193: Because the web language libraries are only loaded inside the iframe and thus in a separate JS context, when unloading the Iframe DOM element, sound and visuals stop.
Strudel also adds some extensions to the Codemirror editor and has an animation frame to update decorators. For some reason, these updates need to run in the same context as the editor, and can't be modified from within the Iframe page.