version 1.0 #9
Open
version 1.0 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsilent
reviewed
Apr 4, 2020
| @@ -0,0 +1,45 @@ | |||
| 1585294247976:help | |||
pavelsilent
reviewed
Apr 4, 2020
|
|
||
| @Bean | ||
| public RestTemplate getRestTemplate(){ | ||
|
|
There was a problem hiding this comment.
Лишние строки в коде - это делает код более громоздким и неудобным для чтения.
pavelsilent
reviewed
Apr 4, 2020
| @Override | ||
| public List<String> selectAll() { | ||
|
|
||
| return jdbcTemplate.query(SQL_SELECT_ALL, ((rs,rowNum) -> |
There was a problem hiding this comment.
Форматирование затрудняет чтение кода.
pavelsilent
reviewed
Apr 4, 2020
|
|
||
| headers = new HttpHeaders(); | ||
| headers.set("x-rapidapi-host", "community-open-weather-map.p.rapidapi.com"); | ||
| headers.set("x-rapidapi-key", "cdd96ad95amsheebcca53e65aac1p136010jsn18e30e4e6350"); |
There was a problem hiding this comment.
Не очень безопасно держать здесь ключ, т.к. его все видят. Попробуйте убрать в переменные окружения.
pavelsilent
reviewed
Apr 4, 2020
| @Service | ||
| public class WeatherServiceImpl implements WeatherService { | ||
|
|
||
| private final static String URL = "https://community-open-weather-map.p.rapidapi.com/weather?q="; |
There was a problem hiding this comment.
Хедеры и урлы - тоже можно убрать в переменные.
|
Хорошая работа. Есть несколько замечаний. Попробуйте их устранить. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.