Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subcommands to CLI to run the full Mun pipeline from the command-line #6

Merged
merged 4 commits into from
Oct 6, 2019
Merged

Add subcommands to CLI to run the full Mun pipeline from the command-line #6

merged 4 commits into from
Oct 6, 2019

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented Oct 4, 2019

  • Add compiler daemon that watches file system events and recompiles changed files
  • Add --watch argument to the build subcommand to launch the compiler daemon
  • Add start subcommand to launch the runtime

@Wodann Wodann self-assigned this Oct 4, 2019
baszalmstra
baszalmstra requested changes Oct 4, 2019
View reviewed changes
Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All together great PR. My biggest concern, but that is not required for this PR, is that currently none of the incremental compilation architecture is used. If we merge this PR we'll have to add that to the backlog.

crates/mun/src/main.rs Show resolved Hide resolved
crates/mun_compiler/src/lib.rs Show resolved Hide resolved
crates/mun_compiler_daemon/src/lib.rs Show resolved Hide resolved
crates/mun_runtime/src/lib.rs Outdated Show resolved Hide resolved
@baszalmstra
Copy link
Collaborator

Finish work on the full pipeline

baszalmstra
baszalmstra reviewed Oct 6, 2019
View reviewed changes
crates/mun/src/main.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/lib.rs Show resolved Hide resolved
@Wodann Wodann merged commit b3040d4 into mun-lang:master Oct 6, 2019
@Wodann Wodann deleted the feature/pipeline branch October 21, 2019 15:05
@Wodann Wodann added this to the Mun v0.1.0 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees

@Wodann Wodann

Labels
None yet
Projects
None yet
Milestone
Mun v0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Wodann @baszalmstra