feat: incremental compilation on hot reloading #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
force-pushed
the
incremental_compilation
branch
from
9386c39
to
da0186c
Compare
baszalmstra
force-pushed
the
incremental_compilation
branch
2 times, most recently
from
e316284
to
98ae497
Compare
baszalmstra
changed the title
Wodann
requested changes
Nov 20, 2019
baszalmstra
force-pushed
the
incremental_compilation
branch
from
cbfe89c
to
df50ede
Compare
The notify crate does not properly handle watching of recreated files on all platform. This commit instead watches the parent directory as proposed in the documentation of Notify. See: notify-rs/notify#166
Co-Authored-By: Wodann <[email protected]>
baszalmstra
force-pushed
the
incremental_compilation
branch
from
df50ede
to
77f6f64
Compare
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 70.43% 70.85% +0.41%
==========================================
Files 102 106 +4
Lines 6813 6838 +25
==========================================
+ Hits 4799 4845 +46
+ Misses 2014 1993 -21
Continue to review full report at Codecov.
|
Merged
Wodann
approved these changes
Nov 21, 2019
Wodann
changed the title
Wodann
changed the title
Wodann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit restructures the compiler crates to better support incremental compilation. The compiler
--watchmode is now incremental, reusing the state from previous compilations.Todo:
Driver--watchmode incremental withDriver--watchmode works