Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mut keyword #305

Closed
wants to merge 0 commits into from
Closed

feat: add mut keyword #305

wants to merge 0 commits into from

Conversation

mkhan45
Copy link
Contributor

@mkhan45 mkhan45 commented Jan 28, 2021

Adds the mut keyword and updates a lot of tests to accomodate for it.

Closes #199.

🎉

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #305 (b8f33ac) into master (e987aa6) will decrease coverage by 0.00%.
The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   81.42%   81.41%   -0.01%     
==========================================
  Files         239      240       +1     
  Lines       14026    14073      +47     
==========================================
+ Hits        11420    11457      +37     
- Misses       2606     2616      +10     
Impacted Files Coverage Δ
crates/mun_codegen/src/test.rs 100.00% <ø> (ø)
crates/mun_compiler/src/diagnostics.rs 100.00% <ø> (ø)
crates/mun_runtime/tests/marshalling.rs 98.20% <ø> (ø)
crates/mun_hir/src/diagnostics.rs 62.17% <66.66%> (+0.12%) ⬆️
crates/mun_hir/src/ty/infer.rs 72.78% <75.00%> (+0.06%) ⬆️
crates/mun_hir/src/ty/infer/mut_bind.rs 75.00% <75.00%> (ø)
crates/mun_codegen/src/ir/body.rs 83.70% <100.00%> (ø)
crates/mun_hir/src/expr.rs 87.71% <100.00%> (+0.05%) ⬆️
crates/mun_hir/src/ty/tests.rs 97.67% <100.00%> (+0.02%) ⬆️
crates/mun_syntax/src/ast/extensions.rs 85.10% <100.00%> (+0.49%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e987aa6...b8f33ac. Read the comment docs.

Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great PR! I've added some cosmetic comments but other than that it looks good to me!

crates/mun_codegen/src/ir/body.rs Outdated Show resolved Hide resolved
crates/mun_codegen/src/ir/body.rs Outdated Show resolved Hide resolved
crates/mun_hir/src/diagnostics.rs Outdated Show resolved Hide resolved
crates/mun_hir/src/ty/infer.rs Outdated Show resolved Hide resolved
crates/mun_hir/src/ty/infer/mut_bind.rs Outdated Show resolved Hide resolved
crates/mun_syntax/src/parsing/grammar/patterns.rs Outdated Show resolved Hide resolved
crates/mun_syntax/src/tests/parser.rs Outdated Show resolved Hide resolved
@mkhan45
Copy link
Contributor Author

mkhan45 commented May 29, 2021

I didn't mean to close this; I think I updated the wrong branch on my side. I'll fix it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable mutability
2 participants