Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: adds logging to windows llvm install #301

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

baszalmstra
Copy link
Collaborator

@baszalmstra baszalmstra commented Jan 16, 2021

Attempt to fix windows build errors with llvm. I couldn't get CI to fail with this PR (of course), so this just adds some logging to hopefully diagnose the problem in the future.

@baszalmstra baszalmstra self-assigned this Jan 16, 2021
@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #301 (9b8cd2b) into master (b7a638e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   80.77%   80.77%           
=======================================
  Files         237      237           
  Lines       13864    13864           
=======================================
  Hits        11199    11199           
  Misses       2665     2665           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a638e...9b8cd2b. Read the comment docs.

@baszalmstra baszalmstra added the type: perf Changes that improve performance label Jan 17, 2021
@baszalmstra baszalmstra marked this pull request as ready for review January 17, 2021 10:28
@baszalmstra baszalmstra merged commit 6081592 into mun-lang:master Jan 19, 2021
@Wodann Wodann added type: build Changes that affect the build system or external dependencies and removed type: perf Changes that improve performance labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: build Changes that affect the build system or external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants