-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(language server): removed async code and switched to lsp_server #295
feat(language server): removed async code and switched to lsp_server #295
Conversation
0a6af9e
to
2b08ebe
Compare
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 78.76% 80.77% +2.00%
==========================================
Files 236 237 +1
Lines 13866 13864 -2
==========================================
+ Hits 10922 11199 +277
+ Misses 2944 2665 -279
Continue to review full report at Codecov.
|
I also added some basic functionalities for testing the language server properly. This now also fixes the shortcomings in #293 where the language server was slower than the tests. With the new vfs we can now wait until the entire workspace is loaded before requesting information about it. |
3bb4624
to
dc79dda
Compare
dc79dda
to
e950f85
Compare
e950f85
to
6a72006
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Some minor change requests.
6a72006
to
7119fe0
Compare
7119fe0
to
c7e0c7b
Compare
Depends on #294
This PR removes all async code and switch to the use of the
lsp_server
crate instead of using our own.