Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont run mun tests on CI #278

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

baszalmstra
Copy link
Collaborator

@baszalmstra baszalmstra commented Oct 10, 2020

This fixes an issue with Netlify not being able to build to book due to it not being able to find the test plugin. This PR comments out the test plugin when running in CI. Since we run the mdbook tests in the CI on Gitlab this is fine.

Fixes: #277

@baszalmstra baszalmstra added type: fix Bug fix or report pri: high An issue resulting in complete or substantial loss of functionality, that can be circumvented labels Oct 10, 2020
@baszalmstra baszalmstra self-assigned this Oct 10, 2020
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #278 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   78.82%   78.82%           
=======================================
  Files         220      220           
  Lines       13070    13070           
=======================================
  Hits        10303    10303           
  Misses       2767     2767           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7dc5ec...18138ed. Read the comment docs.

@Wodann Wodann merged commit d818fe3 into mun-lang:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pri: high An issue resulting in complete or substantial loss of functionality, that can be circumvented type: fix Bug fix or report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs/Book appears to be a 404
2 participants