Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use '->' instead of ':' for fn return types #123

Merged
merged 3 commits into from
Apr 9, 2020
Merged

refactor: use '->' instead of ':' for fn return types #123

merged 3 commits into from
Apr 9, 2020

Conversation

wackbyte
Copy link
Contributor

@wackbyte wackbyte commented Apr 9, 2020

Closes #105. I updated all of the tests but not the README example.

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #123 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   78.87%   78.86%   -0.02%     
==========================================
  Files         141      141              
  Lines        8724     8728       +4     
==========================================
+ Hits         6881     6883       +2     
- Misses       1843     1845       +2     
Impacted Files Coverage Δ
crates/mun_codegen/src/test.rs 97.36% <ø> (ø)
crates/mun_hir/src/tests.rs 84.61% <ø> (ø)
crates/mun_hir/src/ty/tests.rs 96.05% <ø> (ø)
crates/mun_runtime/src/test.rs 98.25% <ø> (ø)
crates/mun_runtime_capi/src/tests.rs 99.29% <ø> (ø)
crates/mun_syntax/src/tests/lexer.rs 100.00% <ø> (ø)
crates/mun_syntax/src/tests/parser.rs 100.00% <ø> (ø)
crates/mun_syntax/src/parsing/parser.rs 80.00% <50.00%> (-0.41%) ⬇️
crates/mun_syntax/src/syntax_kind/generated.rs 64.28% <50.00%> (-0.12%) ⬇️
...tes/mun_syntax/src/parsing/grammar/declarations.rs 88.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105755c...bbbb5d7. Read the comment docs.

crates/mun_syntax/src/grammar.ron Outdated Show resolved Hide resolved
@baszalmstra
Copy link
Collaborator

Also, why not change the README? that should reflect what the language looks like currently.

@wackbyte
Copy link
Contributor Author

wackbyte commented Apr 9, 2020

I'll update the mun_runtime example as well.

@wackbyte
Copy link
Contributor Author

wackbyte commented Apr 9, 2020

It looks like I forgot to add the arrow to the symbols test, too.

@wackbyte
Copy link
Contributor Author

wackbyte commented Apr 9, 2020

Did I miss anything else?

@baszalmstra
Copy link
Collaborator

Did I miss anything else?

I think you missed these : https://github.com/mun-lang/mun/tree/master/crates/mun_runtime/benches/resources

@baszalmstra baszalmstra merged commit 5ea272f into mun-lang:master Apr 9, 2020
@wackbyte wackbyte deleted the colon-to-arrow branch April 12, 2020 22:20
@Wodann Wodann changed the title Use '->' instead of ':' for fn return types refactor: use '->' instead of ':' for fn return types May 2, 2020
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace return type annotation : with ->
3 participants