No USER in dockerfile anymore #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
reviewed
Jun 3, 2024
Krzmbrzl
reviewed
Jun 29, 2024
| system, in order to cause minimal issues when accessing mounted volumes. | ||
| By default, the entrypoint will `chown` the `/data` folder to have good rights on the mounted folder. If your system don't allow changing owner from the container itself or if you don't want to entrypoint to modify the rights in any way other by you, you can set the environment variable : `MUMBLE_NO_CHOWN` to `true`. |
There was a problem hiding this comment.
Suggested change
| By default, the entrypoint will `chown` the `/data` folder to have good rights on the mounted folder. If your system don't allow changing owner from the container itself or if you don't want to entrypoint to modify the rights in any way other by you, you can set the environment variable : `MUMBLE_NO_CHOWN` to `true`. | |
| By default, the entrypoint will `chown` the `/data` folder to have the necessary permissions in the mounted directory. If your system doesn't allow this from within the container or if you don't want this behavior for other reasons, you can set the environment variable : `MUMBLE_NO_CHOWN` to `true`. |
| groupmod -og "$MUMBLE_GID" mumble | ||
| usermod -ou "$MUMBLE_UID" mumble | ||
| if [[ "$MUMBLE_CHOWN" = true ]]; then | ||
| echo "Changing owner of folder {DATA_DIR}" |
There was a problem hiding this comment.
Suggested change
| echo "Changing owner of folder {DATA_DIR}" | |
| echo "Changing owner of folder ${DATA_DIR}" |
| usermod -ou "$MUMBLE_UID" mumble | ||
| if [[ "$MUMBLE_CHOWN" = true ]]; then | ||
| echo "Changing owner of folder {DATA_DIR}" | ||
| chown -R mumble:mumble ${DATA_DIR} |
There was a problem hiding this comment.
Suggested change
| chown -R mumble:mumble ${DATA_DIR} | |
| chown -R mumble:mumble "${DATA_DIR}" |
| echo "Changing owner of folder {DATA_DIR}" | ||
| chown -R mumble:mumble ${DATA_DIR} | ||
| fi | ||
| exec runuser -u mumble -g mumble -- "$@" |
There was a problem hiding this comment.
What does this do? If it starts the server, I don't think that should happen here (as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #34