Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the unintended behaviour of the hover effect on the links. #312

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

amin-xiv
Copy link
Contributor

@amin-xiv amin-xiv commented Nov 6, 2024

Description

I made it so that the border is already there, but invisible, and when the user hovers over the links, it will simply change colour, avoiding unintended side effects such as spacing.

Related Issue

Fixes #311

Type of change

  • Bug fix
  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
Dataverse.-.Google.Chrome.2024-11-06.16-49-31.mp4

Copy link
Contributor

github-actions bot commented Nov 6, 2024

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit d7c8b0c
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/672b74419150ad0008b3a45c
😎 Deploy Preview https://deploy-preview-312--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jency1 jency1 merged commit 4034b17 into multiverseweb:main Nov 6, 2024
6 checks passed
Copy link
Contributor

github-actions bot commented Nov 6, 2024

🎉🎉 Thank you for your contribution! Your PR #312 has been merged! 🎉🎉

@amin-xiv amin-xiv deleted the link-spacing-issue branch November 6, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unintended spacing for the links while hovering.
2 participants