Adding Star rating to the feedback form #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better. |
✅ Deploy Preview for multiverse-dataverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
multiverseweb
requested changes
Nov 6, 2024
There was a problem hiding this comment.
The design looks file but there are some minor problems that need to be resolved:
- Remove the style tag from
index.htmlfile and add this styling in the relevant css file that already exists. - If you haven't made any changes in
script.jsfile then copy the contents from the live github repo and paste it as it is, it will save your time resolving the conflicts.
|
@multiverseweb I dont have the write access for the file to resolve conflicts. |
|
@multiverseweb I've made the changes mentioned. |
|
@shriyadindi yeah now it looks good, just create a new cleaner PR so I can merge it as there are many conflicts in this one
|
|
@multiverseweb Okay. |
8 tasks
|
@multiverseweb Created a new PR here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Star rating to the feedback form
Related Issue
Fixes #283
Dataverse.-.Brave.2024-11-05.20-32-08.mp4
Type of change
Checklist