Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved SignUp and Login Pages #228

Closed
wants to merge 1 commit into from

Conversation

Bhum-ika
Copy link

@Bhum-ika Bhum-ika commented Oct 24, 2024

Description

This PR has contributed in the improvement of UI and making those pages responsive

Related Issue

Fixes #208

Type of change

  • Bug fix
  • New feature

Screenshot 2024-10-24 125013
Screenshot 2024-10-24 125023
Screenshot 2024-10-24 125034
Screenshot 2024-10-24 125043

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit a868f81
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/6719f7fb0bae9700089a7261
😎 Deploy Preview https://deploy-preview-228--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from Dataverse team will review it as soon as possible. We appreciate your support in making this project better

@jency1
Copy link
Collaborator

jency1 commented Oct 24, 2024

@Bhum-ika Something went wrong, do check it and fix it. The login / signup page is not working.

Screenshot 2024-10-24 194036

@Bhum-ika
Copy link
Author

Bhum-ika commented Oct 24, 2024

@jency1 kindly have a look on the issue. I only mentioned to improve UI, not functionality
And the issue you are stating, already existed before.

@Bhum-ika
Copy link
Author

@Tejas-Gupta-7 Please have a look

@multiverseweb
Copy link
Owner

Hey @Bhum-ika, the design of the page in this PR is very different as compared to that of the existing website as discussed in #208.
Also, the issue has been resolved here #237, so I'll be closing this PR. Let me know if you want to discuss this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing Login/Signup Pages
3 participants