Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed header styling #225

Closed
wants to merge 1 commit into from

Conversation

BhavaniSankar0107
Copy link

Description

  1. I have added a name after logo and made sure that it will disappear in mobile view
  2. I have also added space between login/signup button and menu option

Type of change

  • New feature
  • Enhancement

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit 0bc918e
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/6718758c37841200084c8cd2
😎 Deploy Preview https://deploy-preview-225--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from Dataverse team will review it as soon as possible. We appreciate your support in making this project better

@jency1
Copy link
Collaborator

jency1 commented Oct 24, 2024

@BhavaniSankar0107 Mention the issue number which you have solved.

And resolve all conflicts.

@BhavaniSankar0107
Copy link
Author

I have solved issue no. #195 , please review changes and assign necessary labels

@multiverseweb
Copy link
Owner

@BhavaniSankar0107 there is problem with the positioning of Login/SignUp button. It overflows to the right of the page in less wide screens.

@multiverseweb
Copy link
Owner

@BhavaniSankar0107 I'm closing this PR as the issue has not been resolved, here is the relevant screen recording:

Screen.Recording.2024-10-31.011831.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants