Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer update #224

Closed
wants to merge 0 commits into from
Closed

Conversation

aashutosh585
Copy link

Hey @multiverseweb ,I have updated Footer of website, Take a look of it if you want some more change ,then let me know

Before

Screenshot 2024-10-22 233257

After

Screenshot 2024-10-23 005007

And don't forgot to add hackcobar-fest gssoc-ext level 2 or level3.

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit f1110a4
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/672105120a13270009c7a3ce
😎 Deploy Preview https://deploy-preview-224--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from Dataverse team will review it as soon as possible. We appreciate your support in making this project better

@jency1
Copy link
Collaborator

jency1 commented Oct 24, 2024

@aashutosh585 Mention the issue number which you have solved.

Also if can add a horizontal line or something at top of all the links, like it is there on top of copyright section.

@aashutosh585
Copy link
Author

aashutosh585 commented Oct 24, 2024

hey @jency1 , Issue Number is #196 .Take a look of modified footer .if you want something else then tell me.
Screenshot 2024-10-25 005215

And don't forgot to add hackcobar-fest gssoc-ext level 2 or level3.

@multiverseweb
Copy link
Owner

@aashutosh585, there are some problems with this PR:

  • you added css code in <style> tag in html file even when style.css exists. It hinders code consistency and disturbs future contributors.
  • The hover effect on links scales up their size, which moves the position of surrounding links a little. It didn't look good to me.

Can you just keep the style of the links as it is in the existing live site and remove the scale-up hover effect?
The main change I would like through this PR is moving the copyright section below the links.
Good luck!

@aashutosh585
Copy link
Author

hey @multiverseweb ,PR no #248 I improve code as your requirement

@multiverseweb
Copy link
Owner

@aashutosh585, there are some problems with this PR:

  • you added css code in <style> tag in html file even when style.css exists. It hinders code consistency and disturbs future contributors.
  • The hover effect on links scales up their size, which moves the position of surrounding links a little. It didn't look good to me.

Can you just keep the style of the links as it is in the existing live site and remove the scale-up hover effect? The main change I would like through this PR is moving the copyright section below the links. Good luck!

@aashutosh585
No commits have been made in this PR after I requested changes. Maybe you forgot to commit? Just check once
These are the animations effect I quoted in the earlier message:

Screen.Recording.2024-10-29.123120.mp4

Hovering on one link, moves the contents around it. Can you remove this animation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants