Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Error Handling and Data Validation in Python Files #201 #213

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Anushka-Pote
Copy link

Description

Enhance the robustness of the Python files in the project by implementing comprehensive error handling and data validation mechanisms. This will ensure the application can handle unexpected scenarios gracefully and provide meaningful feedback to the user.

Related Issue

Fixes #201

Type of change

  • Bug fix
  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit 7ef5871
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/6720fa6ad784320008396999
😎 Deploy Preview https://deploy-preview-213--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from Dataverse team will review it as soon as possible. We appreciate your support in making this project better

@jency1
Copy link
Collaborator

jency1 commented Oct 22, 2024

@Anushka-Pote Resolve all conflicts.

@jency1 jency1 requested a review from multiverseweb October 22, 2024 12:01
@Anushka-Pote
Copy link
Author

Yeah, I got the conflicts, as there was another linear regression model merge made but, before making the PR I resolved all the the conflicts after sync on my local machine itself. You can see it as one of the 5 commits.
I don't think there should be any conflict left, but I will see it again

@jency1
Copy link
Collaborator

jency1 commented Oct 24, 2024

@multiverseweb

@Anushka-Pote
Copy link
Author

Have I resolved the conflicts or any other change is expected?

@multiverseweb
Copy link
Owner

@Anushka-Pote I'm testing the PR, will get back to you soon.

@Anushka-Pote
Copy link
Author

Heyy
Actually tomorrow is the last day for any PR merges to be allowed, so could you please tell me if there needs any changes here or is it fine??

@jency1
Copy link
Collaborator

jency1 commented Oct 29, 2024

Heyy Actually tomorrow is the last day for any PR merges to be allowed, so could you please tell me if there needs any changes here or is it fine??

@Anushka-Pote There are conflicts. So you need to resolve it.

@Anushka-Pote
Copy link
Author

There were conflicts before i agree, but then I had resolved all
I don't know why this is happening again.

Copy link
Owner

@multiverseweb multiverseweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anushka-Pote, there are some problems in this PR:

  • You have removed the variable z which counts the number of failed login attempts so the code is throwing an error in the terminal in that scenario
    image

Add an error message for invalid login attempts. Leave the variable z as it is, I'll later add a feature that disables finance tracker for some time after 2 invalid login attempts

Screenshot 2024-11-10 080515

  • The colors of pie chart are not same as those used in the line chart.

image

This can be solved by adding colors=colors[1:len(columns) + 1] attribute here
image

Kindly solve the stated problems to get the PR merged.

Note

I understand that I'm late in reviewing the code and its the last day of GSSoC, so I'll be merging the PR whether you resolve the stated problems timely or not. Will fix them myself otherwise.
Good luck!

@Anushka-Pote
Copy link
Author

Anushka-Pote commented Nov 10, 2024

Hey I just saw the message right now, And I don't think it will be done by 7 pm to be honest
So how should I work it out?

@multiverseweb
Copy link
Owner

multiverseweb commented Nov 10, 2024

Hey @Anushka-Pote no problem. Just let me know if you can still work on this PR otherwise I can fix the problems too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Error Handling and Data Validation in Python Files
3 participants