Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home page navbar and signup/login back to home button update #185

Closed
wants to merge 2 commits into from

Conversation

saumyayadav25
Copy link

Description

Updated Navbar of home page, updated signup/login page back to home button.
also, in sign up page, there was not enough spacing at the end of the box.

Related Issue

Fixes #171

Before:

before version can be seen in the issue.
Screenshot 2024-10-19 at 4 21 56 PM

After:

Screenshot 2024-10-19 at 4 22 26 PM Screenshot 2024-10-19 at 4 21 39 PM Screenshot 2024-10-19 at 4 20 14 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit dd61021
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/6718e993f43a300008defb1b
😎 Deploy Preview https://deploy-preview-185--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jency1
Copy link
Collaborator

jency1 commented Oct 19, 2024

@saumyayadav25 Yoh have just added padding , there is no change in the feature or something.

@saumyayadav25
Copy link
Author

@saumyayadav25 Yoh have just added padding , there is no change in the feature or something.

yes, in issue i mentioned that the signup/login and menu are overlapping and

in signup and login page both, back to home page was hidden.

So, i was supposed to make those changes only according to the issue.

  • if any other changes are required then do let me know

Copy link
Owner

@multiverseweb multiverseweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @saumyayadav25, you have hard-coded the position of the buttons according to the dimensions if your device's screen. This is how is looks on my computer:
image

This can be solved by making the position absolute rand giving margin from right side to Login/Signup button and from left side to Back to Home button.

Hope you can fix this soon.

@saumyayadav25
Copy link
Author

Hey @saumyayadav25, you have hard-coded the position of the buttons according to the dimensions if your device's screen. This is how is looks on my computer: image

This can be solved by making the position absolute rand giving margin from right side to Login/Signup button and from left side to Back to Home button.

Hope you can fix this soon.

sure, i will fix this issue asap.

@saumyayadav25 saumyayadav25 deleted the user-saumya branch October 23, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlapping and hidden navbar content
3 participants