Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast Fix for #3900 2 #3921

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Fast Fix for #3900 2 #3921

merged 4 commits into from
Jan 3, 2025
+153 −158

Conversation

G-Moris
Copy link
Contributor

@G-Moris G-Moris commented Jan 2, 2025

No description provided.

FileEX
FileEX reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@FileEX FileEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're already on it, wouldn't it be better to rewrite this function using the new parser? It would definitely be more readable

@G-Moris
Copy link
Contributor Author

G-Moris commented Jan 2, 2025

Since you're already on it, wouldn't it be better to rewrite this function using the new parser? It would definitely be more readable

I was asked to fix this, I don't really understand the new style of lua functions, but I'll try.

@G-Moris
Copy link
Contributor Author

G-Moris commented Jan 2, 2025

I was asked to fix this, I don't really understand the new style of lua functions, but I'll try.

Most likely, it is better to do this in a separate PR, since I was asked to make these changes.

@tederis
Copy link
Member

tederis commented Jan 2, 2025 •
edited
Loading

What does exactly this fixes? Or it's a refactor?

@G-Moris
Copy link
Contributor Author

G-Moris commented Jan 2, 2025

What does exactly this fixes? Or it's a refactor?

GetHandlingData essentially cannot produce a nullptr

@botder botder merged commit 711c35e into multitheftauto:master Jan 3, 2025
6 checks passed
@botder botder added this to the 1.6.1 milestone Jan 3, 2025
@botder botder added the refactor label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FileEX FileEX FileEX left review comments

@botder botder botder approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.
5 participants
@G-Moris @tederis @FileEX @botder @Moris-Onz